Bugs

Topic for reporting any problems and bugs.

IMPORTANT NOTE: There is a known issues with installing new plugins in nopCommerce.
Please read this post for more information.

Hi, we use this plugin on our site because we accidentally enabled usernames when we didn't really need to.

Unfortunately, there looks like there may be a bug in this problem - could you try and recreate the issue on your store or a demo? It seems to be appearing in our log quite a bit.

The store crashes if a customer does the following:
- A logged out user or guest loads up a guest shopping cart with a few items
- Goes to the shopping cart, then confirms the order
- Nop sends him to the login/register page
- Customer logs in with username information - no problem. BUT,
- If customer tries to log in with e-mail address (instead of user name) - CRASH.

I've disabled the plugin and it seems to work fine as long as it's not enabled.. I'm guessing that maybe there isn't a mapping route in Nop that's supposed to map the e-mail address instead of the existing username when being sent to the cart with existing items?

Thanks,
Travis

Here is the error:

[quote]Server Error in '/' Application.
Value cannot be null.
Parameter name: toCustomer
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.ArgumentNullException: Value cannot be null.
Parameter name: toCustomer

Source Error:

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.

Stack Trace:


[ArgumentNullException: Value cannot be null.
Parameter name: toCustomer]
   Nop.Services.Orders.ShoppingCartService.MigrateShoppingCart(Customer fromCustomer, Customer toCustomer, Boolean includeCouponCodes) +716
   Nop.Web.Controllers.CustomerController.Login(LoginModel model, String returnUrl, Boolean captchaValid) +575
   lambda_method(Closure , ControllerBase , Object[] ) +250
   System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters) +229
   System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters) +35
   System.Web.Mvc.Async.AsyncControllerActionInvoker.<BeginInvokeSynchronousActionMethod>b__39(IAsyncResult asyncResult, ActionInvocation innerInvokeState) +39
   System.Web.Mvc.Async.WrappedAsyncResult`2.CallEndDelegate(IAsyncResult asyncResult) +67
   System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethod(IAsyncResult asyncResult) +42
   System.Web.Mvc.Async.AsyncInvocationWithFilters.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3d() +72
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.<>c__DisplayClass46.<InvokeActionMethodFilterAsynchronouslyRecursive>b__3f() +385
   System.Web.Mvc.Async.AsyncControllerActionInvoker.EndInvokeActionMethodWithFilters(IAsyncResult asyncResult) +42
   System.Web.Mvc.Async.<>c_

Thank you for reporting about this bug.

We have fixed it.
Please try it.

Version 1.02 - February 07, 2018
- fixed bug with multistore (link).

Support wrote:

I’m sorry, but the problem still exists. The update did not fix the problem.

Also, when I uninstalled the old version and re-installed the updated version, it erased the registered serial number. I tried to find it in my customer account on your website but I cannot find it. Can you please send me a PM with the serial number or attach it somehow to my customer profile? The order number was 33547.

I did a little more investigating to try and pinpoint the problem with the plugin. It seems that the problem is narrowed down to when NopCommerce brings you to the customer login page via the shopping cart when the user tries to checkout without being logged in. However, if the user adds a part to the shopping cart and then logs into their account BEFORE they select checkout, then it does not crash, and it transfers the part to their users shopping cart as it properly should.

The bug is somewhere in the process of the shopping cart being in checkout mode and the login page that Nop automatically sends you to if you’re not logged in.

Thanks

I have sent it... and try to duplicate the problem now....

Can you do one test?
Open the file Global.asax in site root folder and add space bar to the end of the file and save it.
Maybe IIS uses old DLL file from internal .NET cache...
Please try and write me about result...

I try to repeat this problem...

I did as requested - no change. Still crashes. :(

Any ideas? We seem to be getting this error a lot.. would like to clear it up ASAP. If you need access to the store then please let me know.


Thanks

I thought yesterday... I'll write to today...

I think I repeated this bug....

Yes it’s quite easy to replicate the problem. I have the plugin on two of my sites and they both have the same problem. If you’re wondering how to make it crash, just simply do the following:

1) Log out of the store
2) Add a product to the cart
3) Go to Checkout
4) Enter in your user login information (using the EMAIL address, not the username)
5) Click login - Crash.

The important thing is that if you go through that procedure and login with the username instead of the email, it will login with no problem. That’s probably the area to look into.


Cheers

Try to use release 1.03 now. Redownload the plugin and write me about result.
I think I have fixed this bug. I didn't use new route for route LoginCheckoutAsGuest.

Support wrote:

Thank you, that fixed the problem for both sites.

Cheers,
Travis

I am sorry for this terrible bug.
Thank you for your help in solving one.